Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event listener isn't removed when using importHref #4123

Closed
blasten opened this issue Nov 2, 2016 · 0 comments
Closed

Event listener isn't removed when using importHref #4123

blasten opened this issue Nov 2, 2016 · 0 comments
Labels
1.x

Comments

@blasten
Copy link
Contributor

blasten commented Nov 2, 2016

If you use importHref multiple times to get the same resource, two events listeners (load/error) might be added, but only one of them is removed when either event fires. That is causing a memory leak in Shop: Polymer/shop#95.
@blasten blasten added the 1.x label Nov 2, 2016
blasten pushed a commit to blasten/polymer that referenced this issue Nov 2, 2016
Fix Polymer#4123: Memory leak when using importHref
132010e
@blasten blasten mentioned this issue Nov 2, 2016
Merged
sorvell pushed a commit that referenced this issue Nov 2, 2016
Merge pull request #4124 from blasten/import-href-listener
f24dea1 
Fix #4123: Memory leak when using `importHref`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blasten