Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:host(.element-name) leaks globally #3739

Closed
sorvell opened this issue Jun 25, 2016 · 0 comments
Closed

:host(.element-name) leaks globally #3739

sorvell opened this issue Jun 25, 2016 · 0 comments
Assignees
@sorvell

Comments

@sorvell
Copy link
Contributor

sorvell commented Jun 25, 2016

Recently, :host(element-name) shimming was changed to work correctly as element-name but the fix incorrectly shims :host(.element-name) has .element-name. This leaks globally.

Example: http://jsbin.com/fikame/edit?html,output.
@sorvell sorvell self-assigned this Jun 25, 2016
sorvell pushed a commit that referenced this issue Jun 25, 2016
Fixes #3739: correctly shim :host(.element-name) as `element-name.e…
997240a 
…lement-name`.

Also converts `:host(not-element-name)` to a non-matching selector.
@sorvell sorvell mentioned this issue Jun 25, 2016
Merged
sorvell pushed a commit that referenced this issue Jun 28, 2016
Merge pull request #3740 from Polymer/fix-3739
645bcd0 
Fixes #3739: correctly shim `:host(.element-name)` as `element-name.e…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell