Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer.dom(node).nextSibling incorrect after appendChild if node is not last child in composed tree #3730

Closed
sorvell opened this issue Jun 22, 2016 · 0 comments
Closed

Polymer.dom(node).nextSibling incorrect after appendChild if node is not last child in composed tree #3730

sorvell opened this issue Jun 22, 2016 · 0 comments

Comments

@sorvell
Copy link
Contributor

sorvell commented Jun 22, 2016

If ref_node is undefined instead of null, node.__dom.nextSibling is
undefined instead of null too. Because of this, Polymer.dom(node).nextSibling is the
nextSibling in the browser DOM when it should be null.

Here's an example: http://jsbin.com/qokeho/edit?html,output.
@sorvell sorvell mentioned this issue Jun 22, 2016
Closed
kevinpschaaf added a commit that referenced this issue Jun 22, 2016
@kevinpschaaf
Merge pull request #3731 from Polymer/fix-3730
8eeb47f 
Fixes #3730, nextSibling after appendChildFixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sorvell