Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated use of PathObservers to match new API #267

Closed
dfreedm opened this issue Sep 4, 2013 · 2 comments
Closed

Updated use of PathObservers to match new API #267

dfreedm opened this issue Sep 4, 2013 · 2 comments
Labels
blocking bug

Comments

@dfreedm
Copy link
Member

dfreedm commented Sep 4, 2013

observe-js has changed the PathObserver API in a breaking way. We need to update.

Commit in question: googlearchive/observe-js@4190641#commitcomment-4008291
@dfreedm
Copy link
Member Author

dfreedm commented Sep 4, 2013

Most obvious example of new API: googlearchive/observe-js@4190641#L1L321

sjmiles pushed a commit that referenced this issue Sep 4, 2013
use new Path api (see #267)
cc63fcb
@dfreedm
Copy link
Member Author

dfreedm commented Sep 7, 2013

Fixed by @sjmiles commit

@dfreedm dfreedm closed this as completed Sep 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocking bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfreedm