Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying splices containing add-before-remove changes (i.e. move) breaks Collection #2261

Closed
kevinpschaaf opened this issue Aug 12, 2015 · 1 comment
Closed

Applying splices containing add-before-remove changes (i.e. move) breaks Collection #2261

kevinpschaaf opened this issue Aug 12, 2015 · 1 comment
Assignees
@kevinpschaaf
Labels
p0

Comments

@kevinpschaaf
Copy link
Member

Minimum repro:
http://jsbin.com/jocowevohi/edit?html,output (add before remove: bad)
vs.
http://jsbin.com/lenapi/edit?html,output (remove before add: good)

More complicated sort:
http://jsbin.com/sofejo/edit?html,output
@kevinpschaaf
Copy link
Member Author

Fixed sort repro using fix branch: http://jsbin.com/tajeda/edit?html,output

@kevinpschaaf kevinpschaaf self-assigned this Aug 12, 2015
sorvell pushed a commit that referenced this issue Aug 13, 2015
Merge pull request #2262 from Polymer/2261-kschaaf-collection-sort
104f98c 
Reduce keySplices to minimum change set before notifying. Fixes #2261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinpschaaf