Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid childNodes on previous parent is returned after calling domApi.appendChild #2235

Closed
eeid26 opened this issue Aug 9, 2015 · 2 comments
Closed

Invalid childNodes on previous parent is returned after calling domApi.appendChild #2235

eeid26 opened this issue Aug 9, 2015 · 2 comments
Assignees
@sorvell
Labels
in progress p1

Comments

@eeid26
Copy link

eeid26 commented Aug 9, 2015

http://jsbin.com/litugehexu/edit?html,console,output

Also the following issue could be a different mutation of the reported issue. Both issue are due to caching the _lightChildren on the parent

After calling domApi(customElement).appendChild(domApi(customElement).nextSibling) and then flush, the nextSibling of the custom element is not reported correctly by domApi.

http://jsbin.com/hijoxawewa/edit?html,console,output
@sorvell sorvell added the p1 label Aug 10, 2015
@sorvell sorvell self-assigned this Aug 10, 2015
@sorvell
Copy link
Contributor

sorvell commented Aug 10, 2015

Thanks for the detailed reproductions. Yes, both issues look like the same problem.

kevinpschaaf added a commit that referenced this issue Aug 11, 2015
@kevinpschaaf
Merge pull request #2243 from Polymer/fix-2235
5a482c6 
Fixes #2235. Manages logical information in shady distribution more d…
@eeid26
Copy link
Author

eeid26 commented Aug 11, 2015

Thank you. it's working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
in progress p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sorvell @eeid26