Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom properties fail to resolve when an element is attached to an unknown shadowRoot #2078

Closed
sorvell opened this issue Jul 13, 2015 · 0 comments
Assignees
Labels

Comments

@sorvell
Copy link
Contributor

sorvell commented Jul 13, 2015

Given an element added to an unknown shadowRoot like this:

var root = unknownHostElement.createShadowRoot();
root.appendChild(document.createElement('x-foo'));

An exception will occur due to the fact that it's assumed that the dom host of the x-foo element has a known styling api which can be interrogated. In this case the dom host of x-foo is not a Polymer element. We'll need to make the property resolver smarter about finding a styling host to avoid this problem and ensure that elements in unknown hosts are properly styled.

@sorvell sorvell self-assigned this Jul 13, 2015
@sorvell sorvell added the p0 label Jul 13, 2015
kevinpschaaf added a commit that referenced this issue Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant