Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Under native ShadowDOM "dom-if" doesn't stamp out the content even when "if" property is true #1582

Closed
frankiefu opened this issue May 21, 2015 · 0 comments · Fixed by #1597
Closed

Under native ShadowDOM "dom-if" doesn't stamp out the content even when "if" property is true #1582

frankiefu opened this issue May 21, 2015 · 0 comments · Fixed by #1597
Assignees
@sorvell
Labels
p1

Comments

@frankiefu
Copy link
Member

Tapping on the paper-tab should show the ripple effect but it doesn't under native ShadowDOM. In paper-tab's template it has paper-ripple inside a <template is="dom-if"> and even when if property is true the paper-ripple still not getting stamped.

Note: this is on polymer#master

paper-tab.html

...
<template>

  <div class="tab-content flex auto center-center horizontal layout">
    <content></content>
  </div>

  <template is="dom-if" if="{{!noink}}">
    <paper-ripple id="ink" initial-opacity="0.95" opacity-decay-velocity="0.98"></paper-ripple>
  </template>

</template>
...

app.html

<!doctype html>
<html>
<head>

  <title></title>
  <meta charset="utf-8">
  <script src="../../../polymer/components/webcomponentsjs/webcomponents-lite.js"></script>
  <link rel="import" href="x-app.html">

</head>
<body>

  <x-app></x-app>

</body>
</html>

x-app.html

<link rel="import" href="../../../polymer/components/polymer/polymer.html">
<link rel="import" href="../../../polymer/components/paper-tabs/paper-tabs.html">
<link rel="import" href="../../../polymer/components/paper-tabs/paper-tab.html">

<dom-module id="x-app">

  <style>

    paper-tabs {
      background: #00bcd4;
    }

  </style>

  <template>

    <paper-tabs>
      <paper-tab>Foo</paper-tab>
      <paper-tab>Bar</paper-tab>
      <paper-tab>Zot</paper-tab>
    </paper-tabs>

  </template>

  <script>

    Polymer({

      is: 'x-app'

    });

  </script>

</dom-module>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1565,1582,1584 fix Polymer/polymer
3 participants
@sorvell @frankiefu @kevinpschaaf