Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.9] Gesture event throws exception when dragged outside document #1574

Closed
Sleeckx opened this issue May 20, 2015 · 0 comments · Fixed by #1579
Closed

[0.9] Gesture event throws exception when dragged outside document #1574

Sleeckx opened this issue May 20, 2015 · 0 comments · Fixed by #1579
Assignees
@dfreedm

Comments

@Sleeckx
Copy link

Sleeckx commented May 20, 2015

The following line throws an exception when you drag the element outside the document:
https://github.com/Polymer/polymer/blob/master/src/standard/gestures.html#L103
_Uncaught TypeError: Cannot read property 'shadowRoot' of null_

While doing so may not serve any practical use, a user might do this by accident and the errors don't look nice in the console.
dfreedm added a commit that referenced this issue May 20, 2015
@dfreedm
Use more resiliant shadowroot checking
e3d8ce8 
Also avoid cases where shadowRoot.elementFromPoint returns null
Fixes #1574 [0.9] Gesture event throws exception when dragged outside document
@dfreedm dfreedm mentioned this issue May 20, 2015
Merged
dfreedm added a commit that referenced this issue May 20, 2015
@dfreedm
Use more resiliant shadowroot checking
2bd1290 
Fixes #1574 [0.9] Gesture event throws exception when dragged outside document

Move targetfinding to Gestures object for testing
Add tests
dfreedm added a commit that referenced this issue May 20, 2015
@dfreedm
Use more resiliant shadowroot checking
ee7c628 
Fixes #1574 [0.9] Gesture event throws exception when dragged outside document

Move targetfinding to Gestures object for testing
Add tests
dfreedm added a commit that referenced this issue May 21, 2015
@dfreedm
Use more resiliant shadowroot checking
8f05e43 
Fixes #1574 [0.9] Gesture event throws exception when dragged outside document

Move targetfinding to Gestures object for testing
Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreedm dfreedm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use more resiliant shadowroot checking Polymer/polymer
3 participants
@dfreedm @kevinpschaaf @Sleeckx