-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document native dom properties that are problematic to override #123
Comments
Implementing the title property in a custom element prototype causes an issue with mdv (https://github.com/toolkitchen/toolkit/issues/97). |
HTMLElement.properties is defined as read-only but configurable so a custom element need to define properties in its prototype if it wants to use it. (breaks on firefox) |
I noticed this when attempting to template-bind a custom element that implemented "title" or "id" as a published property. <polymer-element name="greetings-list" attributes="list">
<template>
<template repeat="{{g in list}}">
<paper-card title="{{g.text}}"></paper-card>
</template>
... If element paper-card publishes "title" as an attribute, then the above will not work (the string "{{g.text}}" gets passed in instead of the g.text value). (Polymer 0.3.4) |
Are there any native properties/methods that are NOT problematic to override? I added a blanket caution here (Polymer/old-docs-site#530), but it is somewhat vague. Wording suggestions welcome! |
We'd also like to issue a warning in this case, see: |
How will this problem with (I assume) HTML5 global attributes and JS Object properties affect forward-compatibility of Polymer components? It sounds like if someone adds more attributes/properties to the standards, we risk ruining existing components. Namespacing comes to mind, but is of course less than desirable. |
Closing this issue due to age and the release of version 1 release of Polymer - please feel free to re-open if this is incorrect. |
e.g. appendChild, removeChild, and various native properties...
The text was updated successfully, but these errors were encountered: