Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Document inferred name in Polymer() #530

Closed
wants to merge 6 commits into from

Conversation

arthurevans
Copy link

Fixes #351. Also removed the tag-name argument from many code excerpts on this page.

Also clarified (I hope) section on adding properties and methods.

Wording on both of these may be somewhat controversial, so @sjmiles, @sorvell, PTAL.

<template>
<!-- shadow DOM here -->
</template>
<script>Polymer();</script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should show this as:

Polymer({
...
});

otherwise, just use noscript

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point in the doc, we haven't introduced the proto-object yet... It is synonymous with noscript, true...

Hm. I originally had this section up right after the initial definition, so the parallel was really obvious. Let me think on that.

@ebidel
Copy link
Contributor

ebidel commented Aug 13, 2014

Ready to merge?

@arthurevans
Copy link
Author

Dude, aren't you on vacation?

@ebidel
Copy link
Contributor

ebidel commented Aug 14, 2014

I lurk
On Aug 14, 2014 12:37 AM, "Arthur Evans" [email protected] wrote:

Dude, aren't you on vacation?


Reply to this email directly or view it on GitHub
#530 (comment).

@addyosmani
Copy link
Member

@arthurevans Not on vaca anymore here: ready to merge? ; )

@addyosmani
Copy link
Member

Checked with Arthur. We're going to wait on Scott to review before moving forward on this. Arthur says it'll be reviewed before the end of the week.

@arthurevans arthurevans assigned sjmiles and unassigned ebidel Aug 20, 2014
@arthurevans
Copy link
Author

Assigning this to Scott. Feet, meet fire.

@sorvell
Copy link

sorvell commented Aug 21, 2014

We've improved the core feature here. The name-less call Polymer({}) is now supported everywhere. See https://github.com/Polymer/polymer-dev/issues/81.

@arthurevans
Copy link
Author

Git history is all messed up here. Rebased & resubmitted as #617.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Inferred element name in Polymer()
5 participants