Skip to content

Commit

Permalink
Merge pull request #5343 from Polymer/gen-tsd-binary
Browse files Browse the repository at this point in the history
Use type generator binary instead of gulp script.
  • Loading branch information
aomarks authored Aug 24, 2018
2 parents 7791ee9 + a5afc8f commit c7ee777
Show file tree
Hide file tree
Showing 4 changed files with 1,698 additions and 3,224 deletions.
11 changes: 0 additions & 11 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,16 +115,6 @@ gulp.task('generate-externs', gulp.series('clean', async () => {
await fs.writeFile('externs/closure-types.js', `${header}${declarations}`);
}));

gulp.task('generate-typescript', async () => {
let genTs = require('@polymer/gen-typescript-declarations').generateDeclarations;
await del(['**/*.d.ts', '!interfaces.d.ts', '!node_modules/**']);
const config = await fs.readJson(path.join(__dirname, 'gen-tsd.json'));
const files = await genTs(__dirname, config);
for (const [filePath, contents] of files) {
await fs.outputFile(path.join(__dirname, filePath), contents);
}
});

const runClosureOnly = ({lintOnly}) => () => {
let entry, splitRx, joinRx, addClosureTypes;

Expand Down Expand Up @@ -274,7 +264,6 @@ gulp.task('lint-eslint', function() {
gulp.task('lint', gulp.series('lint-eslint'));

// TODO(timvdlippe): Add back `'generate-externs',` once we can generate externs again
gulp.task('generate-types', gulp.series('generate-typescript'));

gulp.task('update-version', () => {
return gulp.src('lib/utils/boot.js')
Expand Down
Loading

0 comments on commit c7ee777

Please sign in to comment.