Merge pull request #5202 from Polymer/3.x-linter-warnings

Fix ESLint gulp task for 3.x

.eslintrc.json

@@ -1,7 +1,9 @@
 {
   "extends": "eslint:recommended",
+  "parser": "babel-eslint",
   "parserOptions": {
-    "ecmaVersion": 6
+    "ecmaVersion": 6,
+    "sourceType": "module"
   },
   "rules": {
     "no-console": "off",

.travis.yml

@@ -1,23 +1,23 @@
 language: node_js
 sudo: false
 dist: trusty
-node_js: stable
+node_js: '9'
 addons:
   firefox: latest
   chrome: stable
 cache:
   directories:
   - node_modules
 before_script:
-- npm install -g bower gulp-cli@1
-- bower install
+- npm install -g gulp-cli@1
 - gulp lint-eslint
-- >-
-  npm run update-types && git diff --exit-code || (echo -e
-  '\n\033[31mERROR:\033[0m Typings are stale. Please run "npm run
-  update-types".' && false)
+# TODO(dfreedm): re-enable after making update-types work
+#- >-
+#  npm run update-types && git diff --exit-code || (echo -e
+#  '\n\033[31mERROR:\033[0m Typings are stale. Please run "npm run
+#  update-types".' && false)
 script:
-- wct -l chrome -l firefox
+- wct --npm --module-resolution=node -l chrome -l firefox
 - if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then travis_wait 30 ./util/travis-sauce-test.sh; fi
 env:
   global:

gulpfile.js

@@ -124,13 +124,13 @@ gulp.task('closure', ['generate-externs'], () => {
     addClosureTypes = new AddClosureTypeImport(entry, 'externs/polymer-internal-types.html');
   }
 
-  config('polymer.html');
+  config('polymer-legacy.js');
 
   const project = new PolymerProject({
     shell: `./${entry}`,
     fragments: [
-      'bower_components/shadycss/apply-shim.html',
-      'bower_components/shadycss/custom-style-interface.html'
+      'node_modules/@webcomponents/shadycss/entrypoints/apply-shim.js',
+      'node_modules/@webcomponents/shadycss/entrypoints/custom-style-interface.js'
     ],
     extraDependencies: [
       addClosureTypes.importPath,
@@ -219,8 +219,8 @@ gulp.task('estimate-size', ['clean'], () => {
   const project = new PolymerProject({
     shell: POLYMER_LEGACY,
     fragments: [
-      'bower_components/shadycss/apply-shim.html',
-      'bower_components/shadycss/custom-style-interface.html'
+      'node_modules/@webcomponents/shadycss/entrypoints/apply-shim.js',
+      'node_modules/@webcomponents/shadycss/entrypoints/custom-style-interface.js'
     ]
   });
 
@@ -250,7 +250,7 @@ gulp.task('estimate-size', ['clean'], () => {
 });
 
 gulp.task('lint-eslint', function() {
-  return gulp.src(['lib/**/*.html', 'test/unit/*.html', 'util/*.js'])
+  return gulp.src(['lib/**/*.js', 'test/unit/*.{html,js}', 'util/*.js'])
     .pipe(eslint())
     .pipe(eslint.format())
     .pipe(eslint.failAfterError());
@@ -281,7 +281,7 @@ gulp.task('generate-typescript', async () => {
 });
 
 gulp.task('update-version', () => {
-  return gulp.src('lib/utils/boot.html')
+  return gulp.src('lib/utils/boot.js')
   .pipe(replace(/(window.Polymer.version = )'\d+\.\d+\.\d+'/, `$1'${require('./package.json').version}'`))
   .pipe(gulp.dest('lib/utils'));
 });

lib/utils/boot.js

@@ -8,4 +8,4 @@ Code distributed by Google as part of the polymer project is also
 subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
 */
 
-window.JSCompiler_renameProperty = function(prop, obj) { return prop; }
+window.JSCompiler_renameProperty = function(prop) { return prop; };

lib/utils/debounce.js

@@ -111,4 +111,4 @@ export const Debouncer = class Debouncer {
     debouncer.setConfig(asyncModule, callback);
     return debouncer;
   }
-}
+};

package.json

@@ -13,6 +13,7 @@
     "@polymer/iron-component-page": "3.0.0-pre.12",
     "@polymer/test-fixture": "3.0.0-pre.12",
     "@webcomponents/webcomponentsjs": "^2.0.0-0",
+    "babel-eslint": "^7.2.3",
     "babel-preset-minify": "^0.2.0",
     "del": "^3.0.0",
     "dom5": "^3.0.0",

test/unit/dom-bind.html

@@ -26,7 +26,7 @@
   <script type="module">
 import './dom-bind-elements1.js';
 import './dom-bind-elements2.js';
-/* global earlyDomBind earlyBoundChild declaredXBasic1 declaredXBasic2 declarativeDomBind boundTextDiv container needsHost nonUpgrade*/
+/* global earlyDomBind */
 earlyDomBind.value = 'hi!';
 </script>
 
@@ -77,6 +77,7 @@
 
 suite('dom-bind touched before upgrade', function() {
   test('value binds top-down', function() {
+    /* global earlyBoundChild*/
     assert.equal(earlyBoundChild.textContent, 'hi!');
   });
 });
@@ -88,6 +89,7 @@
   var el2;
 
   setup(function() {
+    /* global declarativeDomBind declaredXBasic1 declaredXBasic2 */
     domBind = declarativeDomBind;
     el1 = declaredXBasic1;
     el2 = declaredXBasic2;
@@ -127,6 +129,7 @@
 
   test('initial value notifies to dom-bind', function() {
     assert.equal(domBind.boundText, 'this text is bound');
+    /* global boundTextDiv */
     assert.equal(boundTextDiv.textContent, 'this text is bound');
   });
 
@@ -206,6 +209,7 @@
   });
 
   test('move dom-bind', function( ) {
+    /* global container */
     container.appendChild(domBind);
 
     assert.equal(container.firstElementChild, el1);
@@ -260,7 +264,7 @@
   });
 
 });
-
+/* global needsHost nonUpgrade */
 suite('timing', function() {
 
   test('late-loaded import should block stamping', function() {

test/unit/globals.html

@@ -15,7 +15,6 @@
   <script src="../../node_modules/wct-browser-legacy/browser.js"></script>
   <script src="../../node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js"></script>
   <script type="module">
-/* global origOwnProps:true */
 window.origOwnProps = Object.getOwnPropertyNames(window).reduce(function(props, prop) {
   return props[prop] = true && props;
 }, {});
@@ -62,8 +61,9 @@
 <global-test></global-test>
 
 <script type="module">
-import { Polymer } from '../../polymer-legacy.js';
+import '../../polymer-legacy.js';
 
+/* global origOwnProps */
 suite('globals', function() {
 
   var expected = {

test/unit/wct-browser-config.js

@@ -9,4 +9,4 @@ window.WCT = {
     'accessibility-developer-tools/dist/js/axs_testing.js',
     '@polymer/test-fixture/test-fixture.js'
 ]
-}
+};

util/minimalDocument.js

@@ -8,8 +8,6 @@
  * subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
  */
 
-'use strict';
-
 const dom5 = require('dom5');
 const parse5 = require('parse5');
 const {Transform} = require('stream');

util/travis-sauce-test.sh

@@ -9,4 +9,4 @@
 # subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
 #
 set -x
-wct -s 'windows 10/microsoftedge@14' -s 'windows 10/microsoftedge@15' -s 'windows 10/microsoftedge@16' -s 'windows 8.1/internet explorer@11' -s 'os x 10.11/safari@9' -s 'macos 10.12/safari@10' -s 'macos 10.13/safari@11' -s 'Linux/chrome@41'
+wct --npm --module-resolution=node -s 'windows 10/microsoftedge@14' -s 'windows 10/microsoftedge@15' -s 'windows 10/microsoftedge@16' -s 'windows 8.1/internet explorer@11' -s 'os x 10.11/safari@9' -s 'macos 10.12/safari@10' -s 'macos 10.13/safari@11' -s 'Linux/chrome@41'