Skip to content

Commit

Permalink
add TODO about need to review finalize api.
Browse files Browse the repository at this point in the history
  • Loading branch information
Steven Orvell committed Aug 23, 2016
1 parent fd72adc commit a0bd642
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/elements/element.html
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@
this.__finalized = value;
}

// TODO(sorvell): need to work on public api surrouding `finalize`.
// Due to meta-programming, it's awkward to make a subclass impl of this.
// However, a user might want to call `finalize` prior to define to do
// this work eagerly. Need to also decide on `finalizeConfig(config)` and
// `finalizeTemplate(template)`. Both are public but have simiarly
// awkward subclassing characteristics.
static _finalize() {
var proto = this.prototype;
if (!this._finalized) {
Expand Down

0 comments on commit a0bd642

Please sign in to comment.