Merge pull request #2684 from Polymer/gesture-sd-polyfill-fix

Fix Gestures when using SD polyfill
Polymer · Nov 6, 2015 · 951031f · 951031f
2 parents e72fdee + 96e4bfa
commit 951031f
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 2 deletions.
diff --git a/src/standard/gestures.html b/src/standard/gestures.html
@@ -199,8 +199,11 @@
     handleNative: function(ev) {
       var handled;
       var type = ev.type;
-      var node = ev.currentTarget;
+      var node = wrap(ev.currentTarget);
       var gobj = node[GESTURE_KEY];
+      if (!gobj) {
+        return;
+      }
       var gs = gobj[type];
       if (!gs) {
         return;
@@ -292,6 +295,8 @@
 
     // automate the event listeners for the native events
     add: function(node, evType, handler) {
+      // SD polyfill: handle case where `node` is unwrapped, like `document`
+      node = wrap(node);
       var recognizer = this.gestures[evType];
       var deps = recognizer.deps;
       var name = recognizer.name;
@@ -323,6 +328,8 @@
 
     // automate event listener removal for native events
     remove: function(node, evType, handler) {
+      // SD polyfill: handle case where `node` is unwrapped, like `document`
+      node = wrap(node);
       var recognizer = this.gestures[evType];
       var deps = recognizer.deps;
       var name = recognizer.name;

diff --git a/test/runner.html b/test/runner.html
@@ -41,6 +41,7 @@
       'unit/array-selector.html',
       'unit/events.html',
       'unit/gestures.html',
+      'unit/gestures.html?dom=shadow',
       'unit/utils.html',
       'unit/utils-content.html',
       'unit/utils.html?dom=shadow',

diff --git a/test/unit/gestures-elements.html b/test/unit/gestures-elements.html
@@ -139,3 +139,28 @@
     });
   </script>
 </dom-module>
+
+<dom-module id="x-document-listener">
+  <script>
+  Polymer({
+    is: 'x-document-listener',
+    properties: {
+      stream: {
+        type: Array,
+        value: function() {
+        return [];
+        }
+      }
+    },
+    setup: function() {
+      this.listen(document, 'down', 'handler');
+    },
+    teardown: function() {
+      this.unlisten(document, 'down', 'handler');
+    },
+    handler: function(e) {
+      this.stream.push(e);
+    }
+  });
+  </script>
+</dom-module>
diff --git a/test/unit/gestures.html b/test/unit/gestures.html
@@ -12,7 +12,7 @@
 <head>
   <meta charset="utf-8">
 
-  <script src="../../../webcomponentsjs/webcomponents-lite.js"></script>
+  <script src="../../../webcomponentsjs/webcomponents.js"></script>
   <script src="../../../web-component-tester/browser.js"></script>
 
   <link rel="import" href="../../polymer.html">
@@ -386,6 +386,26 @@
         });
       });
     });
+
+    suite('SD Polyfill', function() {
+      var el;
+      setup(function() {
+        el = document.createElement('x-document-listener');
+        document.body.appendChild(el);
+        el.setup();
+      });
+
+      teardown(function() {
+        el.teardown();
+        document.body.removeChild(el);
+      });
+
+      test('document listener works in SD polyfill', function() {
+        var ev = new CustomEvent('mousedown', {bubbles: true});
+        el.dispatchEvent(ev);
+        assert.equal(el.stream.length, 1);
+      });
+    });
   </script>
 
 </body>