Skip to content

Commit

Permalink
Add comment re: undefined issue
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinpschaaf committed Feb 4, 2019
1 parent d3f27d0 commit 67caf45
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/mixins/property-effects.js
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,11 @@ function parseArg(rawArg) {

function getArgValue(data, props, path) {
let value = get(data, path);
// when data is not stored e.g. `splices`, get the changed value
// when data is not stored e.g. `splices`, get the value from changedProps
// TODO(kschaaf): Note, this can cause a rare issue where the wildcard
// info.value could pull a stale value out of changedProps during a reentrant
// change that sets the value back to undefined.
// https://github.com/Polymer/polymer/issues/5479
if (value === undefined) {
value = props[path];
}
Expand Down

0 comments on commit 67caf45

Please sign in to comment.