Merge pull request #4768 from Polymer/rewrite-expression-parser

Rewrite expression parser to a state machine in optional mixin

bower.json

@@ -26,7 +26,8 @@
   "devDependencies": {
     "web-component-tester": "^6.0.0",
     "test-fixture": "PolymerElements/test-fixture#3.0.0-rc.1",
-    "iron-component-page": "PolymerElements/iron-component-page#^3.0.1"
+    "iron-component-page": "PolymerElements/iron-component-page#^3.0.1",
+    "perf-tester": "polymerlabs/perf-tester"
   },
   "private": true,
   "resolutions": {

externs/closure-types.js

@@ -1379,6 +1379,17 @@ Polymer_ArraySelectorMixin.prototype.select = function(item){};
 Polymer_ArraySelectorMixin.prototype.selectIndex = function(idx){};
 /**
 * @interface
+* @extends {Polymer_PropertyEffects}
+*/
+function Polymer_StrictBindingParser(){}
+/**
+* @param {string} text Text to parse from attribute or textContent
+* @param {Object} templateInfo Current template metadata
+* @return {Array.<!BindingPart>}
+*/
+Polymer_StrictBindingParser._parseBindings = function(text, templateInfo){};
+/**
+* @interface
 * @extends {Polymer_ElementMixin}
 */
 function Polymer_DisableUpgradeMixin(){}

lib/mixins/property-effects.html

@@ -2629,6 +2629,17 @@
        * - Inline computed method (supports negation):
        *   `[[compute(a, 'literal', b)]]`, `[[!compute(a, 'literal', b)]]`
        *
+       * The default implementation uses a regular expression for best
+       * performance. However, the regular expression uses a white-list of
+       * allowed characters in a data-binding, which causes problems for
+       * data-bindings that do use characters not in this white-list.
+       *
+       * Instead of updating the white-list with all allowed characters,
+       * there is a StrictBindingParser (see lib/mixins/strict-binding-parser)
+       * that uses a state machine instead. This state machine is able to handle
+       * all characters. However, it is slightly less performant, therefore we
+       * extracted it into a separate optional mixin.
+       *
        * @param {string} text Text to parse from attribute or textContent
        * @param {Object} templateInfo Current template metadata
        * @return {Array<!BindingPart>} Array of binding part metadata