noscript should now work better when used with CustomElements polyfill.

Polymer · Aug 14, 2013 · 38ce9b4 · 38ce9b4
1 parent 0565e22
commit 38ce9b4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/declaration/polymer-element.js b/src/declaration/polymer-element.js
@@ -38,9 +38,19 @@
         waitPrototype[name] = this;
         // if explicitly marked as 'noscript'
         if (this.hasAttribute('noscript')) {
-          var script = document.createElement('script');
-          script.textContent = 'Polymer(\'' + name + '\');';
-          this.appendChild(script);
+          // TODO(sorvell): CustomElements polyfill awareness:
+          // noscript elements should upgrade in logical order
+          // script injection ensures this under native custom elements;
+          // under imports + ce polyfill, scripts run before upgrades
+          // dependencies should be ready at upgrade time so register
+          // prototype at this time.
+          if (window.CustomElements && !CustomElements.useNative) {
+            element(name);
+          } else {
+            var script = document.createElement('script');
+            script.textContent = 'Polymer(\'' + name + '\');';
+            this.appendChild(script);
+          }
         }
         return;
       }

diff --git a/test/js/register.js b/test/js/register.js
@@ -46,10 +46,8 @@ htmlSuite('element callbacks', function() {
   htmlTest('html/callbacks.html');
 });
 
-htmlSuite('element script', function() {
-  htmlTest('html/element-script.html');
-});
-
 htmlSuite('element registration', function() {
+  htmlTest('html/element-script.html');
   htmlTest('html/element-registration.html');
+  htmlTest('html/element-import.html');
 });