-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
It's surprisingly hard to test precompiled JS using the internal build rules so I plan to figure out how to do the test process below as a sh_test. There are a few issues addressed here: 1. This fixes compiled code envelopes to be compatible with strict mode. In strict mode, a `this` value of null is not replaced with the global object. goog.global = this; and goog.exportSymbol installs the symbols into goog.global by default. 2. Exports need to happen after definition. 3. The curated polymer-1.0 externs do not include some symbols leading to renaming of those symbols in standalone/polymer-resin.js. Tested: Built //third_party/javascript/security/polymer_resin:all, copied the public tarball to a temp directory and did $ tar xf polymer_resin_public.tar $ npm install bower web-component-tester; bower install $ ./run_tests.sh -l chrome ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=159026669
- Loading branch information
1 parent
67dd0bf
commit de72ae9
Showing
7 changed files
with
126 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.