This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Avoid using nested templates when setting innerHTML #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You on on point! We were just about to tackle this issue only to find that you've fixed it already with our proposed solution! |
e111077
suggested changes
Apr 30, 2018
| ]; | ||
| } | ||
| const setDisplayNoneStatment = jsc.expressionStatement(jsc.callExpression( | ||
| const setDisplayNoneStatement = jsc.expressionStatement(jsc.callExpression( |
| @@ -540,7 +540,7 @@ export function createDomNodeInsertStatements( | |||
| jsc.callExpression( | |||
| jsc.memberExpression( | |||
| jsc.identifier('document'), jsc.identifier('createElement')), | |||
| [jsc.literal('div')]))]); | |||
| [jsc.literal('template')]))]); | |||
|
Thanks @web-padawan ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410 by applying the change from Polymer/polymer#5210
This change is