Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Tag element templates with Polymer.html #252

Merged
merged 3 commits into from
Dec 21, 2017
Merged

Tag element templates with Polymer.html #252

merged 3 commits into from
Dec 21, 2017

Conversation

justinfagnani
Copy link
Contributor

Fixes #239

@justinfagnani
Copy link
Contributor Author

Er, don't review yet... I forgot some things

@justinfagnani
Copy link
Contributor Author

Ok, updated some unit tests to make sure that the added Polymer.html references were indeed being converted properly to JS imports. All seems well there.

I still haven't regenerated the fixtures due to what looks like bad fixture generation with my repo. @FredKSchott could you try to see what happens with fixture generation with a clean checkout on your end?

@FredKSchott FredKSchott removed their request for review December 20, 2017 19:10
@FredKSchott
Copy link
Contributor

FredKSchott commented Dec 20, 2017

(Edit, re the above: we talked in person)
LMK when this is ready for another review

@justinfagnani
Copy link
Contributor Author

@FredKSchott rebase, removed workarounds for not having html-tag.html, and ready for review again.

Copy link
Contributor

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I was just thinking of another way to tackle these fixture updates: a lot of the changes are from the fact that source has been updated. we could first regenerate fixtures from the last-used version. Then regenerate from master, and that diff would have much much much less noise.

Something to keep in mind for next time.

@justinfagnani
Copy link
Contributor Author

I was thinking of that yesterday, but had already generated these commits and the change was relatively small. Good idea though.

@justinfagnani justinfagnani merged commit 5725b7e into master Dec 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants