This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Initial scaffolding for the new linter, without any rules implemented yet #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yet. Extracted by rictic from usergenic's #1 PR
usergenic
suggested changes
Dec 21, 2016
| warnings = warnings.concat(await rule.check(document)); | ||
| } | ||
| } catch (error) { | ||
| if (error instanceof WarningCarryingException) { |
There was a problem hiding this comment.
Can we catch per-rule? That way all rules will try to run if one fails.
There was a problem hiding this comment.
If not here, lets file issue and move that code in separate PR?
There was a problem hiding this comment.
+1, reworked how we do error handling here, PTAL
We should never crash based on an analysis error, instead we could just turn that error into a warning on the related file.
usergenic
reviewed
Dec 21, 2016
| warnings = warnings.concat(analysisWarnings); | ||
| for (const document of documents) { | ||
| for (const rule of this._rules) { | ||
| warnings = warnings.concat(await rule.check(document)); |
There was a problem hiding this comment.
Can we add a TODO (or implement?) here to catch exceptions for the rule.check() call? I'd be nice if we had a standard warning to push like we do in the _analyzeAll call.
usergenic
approved these changes
Dec 21, 2016
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted by rictic from usergenic's #1 PR