This repository has been archived by the owner on May 1, 2019. It is now read-only.
Analyze @global functions, and respect @function name override. #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aomarks
force-pushed
the
fn-annotations
branch
5 times, most recently
from
8943532
to
b90e435
Compare
aomarks
changed the title
aomarks
force-pushed
the
fn-annotations
branch
from
b90e435
to
d87f1dd
Compare
|
Huh, looks like a new update changed a few style things with clang-format: I much prefer the whitespace between |
FredKSchott
approved these changes
Nov 30, 2017
|
Yeah, I just ran |
aomarks
added a commit
to Polymer/polymer
that referenced
this pull request
Nov 30, 2017
This will let Analyzer discover it thanks to Polymer/polymer-analyzer#774.
|
Also, the more recent version of clang-format does put the space after async. I'm happy to bump it and run it over everything. |
|
Yes please! (when you have time) |
aomarks
added a commit
to Polymer/polymer
that referenced
this pull request
Nov 30, 2017
This will let Analyzer discover it thanks to Polymer/polymer-analyzer#774.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/Polymer/gen-typescript-declarations/issues/23
(Also ran clang-format, so look at the second commit separately.)