Update polyfill-next-selector docs for #637 #643
Conversation
|
LGTM 👍 |
| or as: | ||
|
|
||
| polyfill-next-selector { content: ':host > *' } | ||
| ::content > * { } |
There was a problem hiding this comment.
Lost the :host prefix. That could be confusing.
There was a problem hiding this comment.
Cool. Since there are two instances of :host in the snippet above, could you confirm if you're referring to:
:host ::content > * { }polyfill-next-selector { content: ':host > *' }- Any mention of
:hostprefix at all :)
There was a problem hiding this comment.
I think it's supposed to be missing the :host prefix. He's demonstrating how to polyfill ::content > * which is one of the only times you actually need polyfill-next-selector
There was a problem hiding this comment.
Right you don't need it, but the two examples should probably match. Or change your example to ::content > * { }
|
LGTM. one comment. |
|
@ebidel I may well have misinterpreted your feedback, but could you take a look and let me know if further changes are needed? |
Update polyfill-next-selector docs for #637
Reviewer: @robdodson
This change attempts to revise the
polyfill-next-selectordocs to only recommend using the feature when doing something that would not work if::contentwere removed. As part of this, I've tried to trim down some of the previous examples that focused on the::contentusecase. If I misunderstood what we were aiming for here, feel free to holler.#637