This repository has been archived by the owner on May 29, 2019. It is now read-only.
document notifySplices and fix render; fixes #1439 #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Call [`render`](/{{versionPrefix}}/api/#dom-repeat:method-render) to force | ||
| a `dom-repeat` template to synchronously render any changes to its data. | ||
| Normally changes are batched and rendered asynchronously. |
There was a problem hiding this comment.
We should add the two use cases here:
Hmm... the first one isn't really a use case, it's more of a general description. I think you could replace it with these two:
- For unit testing, to ensure items have rendered before checking the generated DOM.
- To ensure a list of items have rendered before scrolling to a specific item.
And explicitly note that it does not cause the dom-repeat to pick up changes to the array that were made without the Polymer array mutation methods. If you (or a third-party library) has mutated the array without using the Polymer array mutation methods, you need to use notifySplices (link to section).
This is one of the #1 things that confuses people about using render.
|
Done reviewing. Left a few comments. |
|
OK @arthurevans WDYT? |
| * For unit testing, to ensure items have rendered before checking the | ||
| generated DOM. | ||
| * To ensure a list of items have rendered before scrolling to a | ||
| specific item. |
There was a problem hiding this comment.
- To rerun the
sortorfilterfunctions when an a piece of data changes outside the array (for example, sort order or filter criteria).
|
Caught a couple of other things on 2nd pass. Left comments, otherwise LG. |
kaycebasques
added a commit
that referenced
this pull request
Feb 3, 2016
document notifySplices and fix render; fixes #1439
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arthurevans WDYT?