This repository was archived by the owner on Oct 24, 2021. It is now read-only.
Mixin functions now include all mixins applied transitively #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vely. Previously, only the immediately applied mixins were accounted for, but not ones that were applied transitively. Fixes Polymer/polymer#5087
rictic
reviewed
Feb 13, 2018
src/gen-ts.ts
Outdated
| @@ -447,6 +455,34 @@ function handleMixin(feature: analyzer.ElementMixin, root: ts.Document) { | |||
| ); | |||
| }; | |||
|
|
|||
| /** | |||
| * Mixins can automatically apply other mixins, indicated by the @appliesMixin | |||
| * annotation. However, since mixins may be applied transitively, to know the | |||
There was a problem hiding this comment.
since mixins may be applied transitively -> since mixins may be composed of other mixins
rictic
approved these changes
Feb 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the immediately applied mixins were accounted for, but not ones that were applied transitively.
Fixes Polymer/polymer#5087