SC-19/improve schedule checkpoint module #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyamakgec
changed the title
adamdossa
reviewed
Nov 25, 2019
maxsam4
reviewed
Nov 26, 2019
There was a problem hiding this comment.
Apart from what Adam mentioned, it looks fine overall.
However, I am not sold that we should be doing scheduling onchain. It doesn't seem like worth the increased transfer costs. I'd suggest that scheduling should be done with the help of oracles or just running a service offchain that calls the required function after X days or whatever.
contracts/modules/Checkpoint/Automation/ScheduleCheckpointStorage.sol
Outdated
Show resolved
Hide resolved
|
Added schedules limit validation (<= 10) per discussion with @satyamakgec. |
maxsam4
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.