Unit testing: add explicit revert reason checks #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking into these failed tests... |
|
Ready for review. |
ross-rosario
changed the title
ross-rosario
changed the title
|
Now it's really ready for review. Please check assertions marked with |
satyamakgec
suggested changes
Jul 22, 2019
|
@maxsam4 to review and fixes. It is better to review done by one person so another will take a look into other PR. |
maxsam4
reviewed
Jul 22, 2019
maxsam4
reviewed
Jul 22, 2019
maxsam4
reviewed
Jul 22, 2019
satyamakgec
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...besides that, I've marked cases where expected and actual revert mismatch with
// @FIXME. I'll remove those comments once this PR has been reviewed.