(3.0) Core: ST unit tests:: explicit revert reason checks #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed CTM canTransferBug * Added test case * Added comment for devs
Move some variables / functions to internal
ross-rosario
changed the title
satyamakgec
changed the title
|
Closed in favour of #752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Updating security token unit tests, so that
catchRevertasserts that reversions are caused for the expected reasons.Besides ST unit tests, erroneous reason messages have been removed from remaining tests, as they don't work as intended.
Finally, it seems that
yarn.lockwasn't quite caught up withpackage.json. The former gets overridden every time I runyarn install. Hence, I addedyarn.lockchanges to this PR.What is the current behavior?
N/A
What is the new behavior?
As is.
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Any Other information: