[CLI] Support multiple Stable Coins #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorVicente
suggested changes
Dec 7, 2018
CLI/commands/sto_manager.js
Outdated
| }); | ||
| if (addresses.usdToken == "") addresses.usdToken = usdToken.options.address; | ||
| if (addresses.usdToken == "") { | ||
| listOfAddress = [usdToken.options.address] |
There was a problem hiding this comment.
Why do you have two list of addresses? You can use 'addresses.usdToken' everywhere
There was a problem hiding this comment.
nop, I need to keep both vars. If I remove listOfAddress, processArray brokes.
| for (const type of raiseTypes) { | ||
| let balance = await getBalance(displayWallet, gbl.constants.FUND_RAISE_TYPES[type]); | ||
| let walletBalance = web3.utils.fromWei(balance); | ||
| let walletBalanceUSD = web3.utils.fromWei(await currentSTO.methods.convertToUSD(gbl.constants.FUND_RAISE_TYPES[type], balance).call()); |
There was a problem hiding this comment.
You should check the balance for each stable coin. For example if POLY, ETH, DAI and USDT are accepted, you should show
Balance ETH: xx ETH
Balance POLY: xx POLY
Balance DAI: xx DAI
Balance USDT: xx USDT
There was a problem hiding this comment.
Waiting SC update
VictorVicente
approved these changes
Dec 10, 2018
VictorVicente
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.