Skip to content

Transfer and Approve event naming inconsistencies #412

@monitz87

Description

@monitz87

I found an inconsistency in the naming of the Transfer and Approval event parameters between PolyToken and PolyTokenFaucet. In PolyTokenFaucet all parameters are prefaced by an underscore (i.e. _from, _to, _value), while in PolyToken they are not. This causes inconsistent behavior when switching between mainnet and kovan in the dApp.

I suggest renaming the PolyToken event parameters to include underscores as defined by ERC20

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions