Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Hide Arcade Cosmetics and add simple block command #57

Merged
merged 7 commits into from
Jan 22, 2023

Conversation

xthe-dev
Copy link
Contributor

@xthe-dev xthe-dev commented Jan 21, 2023

Description

  • New: "Hide Arcade Cosmetics"
  • New: simple block command (runs /ignore add name)
  • Add small notification when SilentRemoval is executed
  • Add examples to the config
  • Fix SilentRemoval not working with Remove Guild/Friend Statuses
  • Fix Hide Duels Cosmetics and Hide Arcade Cosmetics hiding items in GUIs

Related Issue(s)

None

How to test

Join a arcade game and see if cosmetics are appearing

Release Notes

New: "Hide Arcade Cosmetics"
New: simple block command (runs /ignore add name)
Added small notification when SilentRemoval is executed
Fixed SilentRemoval not working with Remove Guild/Friend Statuses
Fixed Hide Duels Cosmetics and Hide Arcade Cosmetics hiding items in GUIs

@xthe-dev xthe-dev marked this pull request as draft January 22, 2023 00:03
@xthe-dev
Copy link
Contributor Author

The RenderItemMixin hides items in the inventory and in some GUIs. I don't know how to check this

@Wyvest
Copy link
Member

Wyvest commented Jan 22, 2023

The RenderItemMixin hides items in the inventory and in some GUIs. I don't know how to check this

probably because RenderItem is used in all rendering. Maybe check if the method was called from the world rendering or something

@xthe-dev xthe-dev marked this pull request as ready for review January 22, 2023 12:54
@xthe-dev
Copy link
Contributor Author

Ready to merge, the mixin now injects RenderEntityItem.class

@Wyvest Wyvest merged commit b4fa2cb into Polyfrost:master Jan 22, 2023
@xthe-dev xthe-dev deleted the patch branch January 23, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants