Skip to content

feat: remove manifest from build.rs and leave it to users - #76

Merged
PolyMeilex merged 2 commits into
PolyMeilex:masterfrom
meowtec:enable-comctl6-by-user
Jun 17, 2022
Merged

feat: remove manifest from build.rs and leave it to users#76
PolyMeilex merged 2 commits into
PolyMeilex:masterfrom
meowtec:enable-comctl6-by-user

Conversation

@meowtec

@meowtec meowtec commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Reference: #75 tauri-apps/tauri#4374

In Tauri, use winres for embedding the manifest: tauri-apps/tauri#4383

version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, no need for this autogenerated comment

@meowtec
meowtec force-pushed the enable-comctl6-by-user branch from 2d2ba50 to 6c53cb6 Compare June 17, 2022 17:20

@PolyMeilex PolyMeilex left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@PolyMeilex
PolyMeilex merged commit 1ce3cdb into PolyMeilex:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants