- 
        Couldn't load subscription status. 
- Fork 37
Rendering: Shadows pt 2 #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            99 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      f6b6e56
              
                test case
              
              
                 f1ce6af
              
                calculating light bounds in AABox around frustum in game example for …
              
              
                 4262193
              
                added tight projection around camera frustum, light projection near a…
              
              
                 e1eada7
              
                shadow bug dependent on camera direction
              
              
                 924fc01
              
                imgui reacting to input and drawing on screen from render device
              
              
                sp0lsh cceace4
              
                proper init, render deinit and windows created by game
              
              
                sp0lsh 8d4f0e0
              
                comments
              
              
                sp0lsh f16f8d5
              
                comments
              
              
                sp0lsh 7f23fd5
              
                Merge branch 'dev' into fet/imgui
              
              
                sp0lsh ef0e789
              
                commented #pragma failing travis ci
              
              
                sp0lsh 8befcc8
              
                removed #pragma
              
              
                sp0lsh c5f2ab8
              
                removed  pragma from resource
              
              
                sp0lsh 4ac9b58
              
                commented unused components
              
              
                sp0lsh c5cab92
              
                commented out wrong variable doh...
              
              
                sp0lsh 8522b8f
              
                prototype of shadow casters culling
              
              
                sp0lsh 3c4215e
              
                moved code to rendering device, tested on example scene and on sponza…
              
              
                sp0lsh 1bd2719
              
                added AABox around every drawn mesh and still fails on sponza
              
              
                sp0lsh a999afa
              
                removed shadow casters AABox
              
              
                sp0lsh 5d78698
              
                stable shadows working on sponza and test scene
              
              
                sp0lsh 9bd85a7
              
                stable shadowmap
              
              
                sp0lsh a121570
              
                interpolated Percentage Closer Filtering
              
              
                sp0lsh 168d9a4
              
                shadows prototype cleanup
              
              
                sp0lsh 85866ba
              
                shadow ramblings
              
              
                sp0lsh 3ee3414
              
                Merge branch 'dev' into fet/imgui
              
              
                sp0lsh b2eddea
              
                merged with dev
              
              
                sp0lsh 1210c94
              
                cmake attempt
              
              
                sp0lsh b22bd5a
              
                moved imgui to third parties, cmake updated for Engine, RenderingDevi…
              
              
                sp0lsh 003f1e7
              
                removed sanity spam
              
              
                sp0lsh 3d02fa9
              
                resource cleanup
              
              
                sp0lsh c4ee972
              
                imguisystem cleanup
              
              
                sp0lsh f3aacaf
              
                imgui world component cleanup
              
              
                sp0lsh e1711fa
              
                added non windows API attributes to imconfig.h
              
              
                sp0lsh d5001ab
              
                moved imgui to pch
              
              
                sp0lsh 0f58768
              
                silencing third party gcc -Wimplicit-fallthrough=
              
              
                sp0lsh 2b5a565
              
                enabled -fPIC (Position Independent Code) for imgui static lib to be …
              
              
                sp0lsh 3113e77
              
                fixing gcc includes
              
              
                sp0lsh bc8c094
              
                fixing cgg includes
              
              
                sp0lsh 78d1a90
              
                made includes same as in GLTextureDeviceProxy
              
              
                sp0lsh ab80981
              
                removed commented out code
              
              
                sp0lsh b9fb4b7
              
                ImguiUpdate is now in System, Imgui context creation moved to ImguiSy…
              
              
                sp0lsh 7bd9937
              
                moved Imgui to Engine subdirectory
              
              
                sp0lsh 32e5d29
              
                Added clipboard support, tweaked mouse handling and input that can be…
              
              
                sp0lsh 19cca52
              
                added UTF8 char input from keyboard keys
              
              
                sp0lsh 58e2f9a
              
                fixing input consumption (works on all widowns: engine and game)
              
              
                sp0lsh 6984d1d
              
                added output queue and events handled by SDL
              
              
                sp0lsh f0c1cc5
              
                CI fix
              
              
                sp0lsh 354c6c4
              
                CI fix and cleanup
              
              
                sp0lsh 362d1fb
              
                CI fix
              
              
                sp0lsh 470215d
              
                CI fix
              
              
                sp0lsh 1572e31
              
                fix
              
              
                sp0lsh fd3f38c
              
                Merge branch 'fet/imgui' into rendering/shadows-pt-2
              
              
                sp0lsh 9d1561b
              
                Moved getting axis vector from MovementSystem to EntityTransform
              
              
                sp0lsh 23e80d3
              
                shadowmap ortho projection has correct direction based on dir light f…
              
              
                sp0lsh e77e88e
              
                shadowmap projection in [0, 1] range
              
              
                sp0lsh 2351797
              
                stable shadows on frustum transform and properties change
              
              
                sp0lsh 6a58900
              
                shadows prototype with tight bound around frustum and ortho projectio…
              
              
                sp0lsh dbaa34e
              
                more changes
              
              
                sp0lsh b28420f
              
                tweaks to AABB intersection tests
              
              
                sp0lsh c72f2f5
              
                added tweakable shadow bias and glPolygonOffset
              
              
                sp0lsh c9330cf
              
                working evsm2 and evsm4
              
              
                sp0lsh b747335
              
                Merge branch 'rendering/shadows-pt-3' into rendering/shadows-pt-2
              
              
                sp0lsh 3f97ac2
              
                shadow projection working with shadow bounds extended by vertical sha…
              
              
                sp0lsh 917f185
              
                some EVSM4 shadows that work
              
              
                sp0lsh a513a82
              
                created pass with shadowmap
              
              
                sp0lsh ab700b3
              
                switched renderer to use Shadommap pass
              
              
                sp0lsh f9ce34d
              
                parametrizing shadow types
              
              
                sp0lsh 7217fce
              
                EVSM2 seems to work as well
              
              
                sp0lsh f205054
              
                removed debug light parameters, shadowmap pass has pcf and evsm versions
              
              
                sp0lsh 1504210
              
                removed debug variables from light and camera components
              
              
                sp0lsh 6cc8658
              
                Merge branch 'dev' into rendering/shadows-pt-2
              
              
                sp0lsh 69348dc
              
                CI fix
              
              
                sp0lsh 74f5b1e
              
                CI fix
              
              
                sp0lsh 711c1cf
              
                CI fix
              
              
                sp0lsh e543a7a
              
                CI fix
              
              
                sp0lsh d5d0905
              
                CI Fix
              
              
                sp0lsh c68508a
              
                debug rendering cleanup
              
              
                sp0lsh e60202e
              
                cleanup and comments
              
              
                sp0lsh 02279c9
              
                cleanup
              
              
                sp0lsh 8308170
              
                compilation fix
              
              
                sp0lsh 78c1a0e
              
                cleanup
              
              
                sp0lsh c3d708e
              
                cleanup
              
              
                sp0lsh ff522f2
              
                ignore shader dump extension
              
              
                sp0lsh e565d53
              
                fix
              
              
                sp0lsh ed965e4
              
                Added comment for .dump file extention
              
              
                sp0lsh 5ff85ae
              
                cleanup
              
              
                sp0lsh e1e9eb6
              
                AABB unit tests
              
              
                sp0lsh 1afdff3
              
                Merge branch 'rendering/shadows-pt-2' of https://github.com/sp0lsh/Po…
              
              
                sp0lsh ad72f20
              
                Merge branch 'dev' into rendering/shadows-pt-2
              
              
                sp0lsh 3b76a3c
              
                CI fix, tabbed documents
              
              
                sp0lsh 5f36766
              
                CI fix, tabbed documents
              
              
                sp0lsh eb4bb6a
              
                review fix, tabbed code
              
              
                sp0lsh bbf2823
              
                assert and nullptr fix
              
              
                sp0lsh bd69205
              
                None RenderingSettingsComponent fix
              
              
                sp0lsh 880fb99
              
                review fix
              
              
                sp0lsh 39baf37
              
                review fix, updated includes
              
              
                sp0lsh 12abc19
              
                review fix, removed commented code
              
              
                sp0lsh 6518669
              
                magic variable moved to constant
              
              
                sp0lsh 54ce36f
              
                CI fix
              
              
                sp0lsh 2378f9b
              
                CI fix
              
              
                sp0lsh File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is
Vector::absmethod (or at least should be), use it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BasicMath.hpp has Poly::abs for float, double and long double overloads but no Vector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added this to trello.