Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build process #42

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Update build process #42

merged 2 commits into from
Oct 31, 2023

Conversation

sameeul
Copy link
Member

@sameeul sameeul commented Oct 26, 2023

  • Updated build process to create libfilepattern
  • Updated Python package build process. Now, it will check if the C++ package is already installed or not. If installed, it will use that otherwise it will build the C++ library and then link backend against it.

These change will now allow us to have separate c++ and python conda recipe from the same repo.

building libfilepattern and update workflow
@sweep-ai
Copy link

sweep-ai bot commented Oct 26, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sameeul sameeul merged commit e808977 into PolusAI:master Oct 31, 2023
22 checks passed
@sameeul sameeul deleted the libfilepattern branch October 31, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants