Skip to content

Commit

Permalink
use hardcoded docker image, make cosign install on release not optional
Browse files Browse the repository at this point in the history
  • Loading branch information
Poluect committed Dec 7, 2021
1 parent 89dda1d commit 5560fdb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/github-actions-demo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Prepare Docker
id: docker_prep
run: |
DOCKER_IMAGE=${{ secrets.DOCKER_IMAGE }}
DOCKER_IMAGE=skifdh/test
UNIQUE_TAG="`git describe | sed -e 's/^v//'`"
VERSION=${GITHUB_SHA}
if [[ $GITHUB_REF == refs/tags/* ]]; then
Expand Down Expand Up @@ -147,7 +147,6 @@ jobs:
go-version: 1.17

- name: Install Cosign
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')
uses: sigstore/cosign-installer@main
with:
cosign-release: "v1.4.0" # optional
Expand Down Expand Up @@ -300,7 +299,7 @@ jobs:
- name: Generate oci artifact SBOM
uses: anchore/sbom-action@v0
with:
image: ${{ secrets.DOCKER_IMAGE }}@${{ needs.build.outputs.image_digest }}
image: skifdh/test@${{ needs.build.outputs.image_digest }}
artifact-name: oci-sbom.spdx
registry-username: ${{ secrets.DOCKER_USERNAME }}
registry-password: ${{ secrets.DOCKER_PASSWORD }}
Expand Down
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,8 @@ COSIGN_EXPERIMENTAL=1 cosign verify-blob -signature ~/Downloads/checksums.txt.si

### Fork instructions:

Set following secrets in your repo:
1. Set following secrets in your repo:

- DOCKER_IMAGE (`mycollection/myapp`)
- DOCKER_USERNAME
- DOCKER_PASSWORD
- COSIGN_KEY
Expand All @@ -26,8 +25,11 @@ go install github.com/sigstore/cosign/cmd/[email protected]

cosign generate-key-pair
```
, then copy generated key and password to github secrets

Codecov step is standalone, impact only build step, and can be easily commented
2. In `.github/workflows/github-actions-demo.yml` replace `skifdh/test` with your own docker image path.

3. Codecov step is standalone, impact only build step, and can be easily commented

## Preparing before installing scss

Expand Down

0 comments on commit 5560fdb

Please sign in to comment.