Skip to content

Monthly 2021 09+1#4

Merged
haerdib merged 9 commits intomasterfrom
monthly-2021-09+1
Oct 12, 2021
Merged

Monthly 2021 09+1#4
haerdib merged 9 commits intomasterfrom
monthly-2021-09+1

Conversation

@haerdib
Copy link

@haerdib haerdib commented Sep 21, 2021

update to substrate september monthly tag

Befor merge:

  • test with worker

[dependencies.sp-core]
git = "https://github.com/paritytech/substrate.git"
version = "3.0.0"
tag = "monthly-2021-09+1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point all of these to branch=master and then cargo update to the september+1 SHA

Copy link
Author

@haerdib haerdib Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

september+1 SHA seems to cause some problems for GitHub actions, locally it compiles if the tag commit 20a9bbb is selected, but GA does not find it - which makes somewhate sense as the commit 20a9bbb is not in the master branch.

If I instead take the master commit dd297887 , it works also in GA.

Can we agree to use dd297887 instead of the tag SHA?

Or do you know a better solution to my problem?

Additionally please note, that currenlty a "cargo update -p sp-std (or any substrate library) --precise dd297887c653e344c566e976c050b01f7dea8eef" does not work for crates that import substrate library frame-metadata, as it has been removed from it's original position somewhen after the specific tag commit..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please use the master commit dd0fd0e , it works also in GHA.

Copy link

@simonsso simonsso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the PR you wanted me to merge first?

If so press merge below.

@haerdib haerdib merged commit 78bdef9 into master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants