ProtonMail and protonVPN

[erotavlasme]

Type of pull request: product addition
Related issues: No

Adding new product: protonMail and protonVPN

[privacyspy-bot]

Thanks for submitting this pull request. @ibarakaiev has been assigned to review these changes, provide feedback, and determine next steps.

If you haven't already, please ensure your changes pass all the automated tests. Look in the "Checks" box below and "Files changed" tab to see test results.

To learn about the PrivacySpy contribution process, check out the contribution guide.

Note to maintainers: if this pull request passes all tests and code reviews, it should be squashed and merged.

[ibarakaiev]

Hi @erotavlasme, thanks for all your hard work! Unfortunately, I cannot review or merge your pull request as it seems to include too many products (while your title is only ProtonMail and ProtonVPN). Take a look at our guide for how to contribute. It also references Github's tutorial on pull requests, in case you find that helpful. When you create a branch, it should be branched from our master branch, and each branch should only include one product. Let me know if you have any questions!

[erotavlasme]

Hi @ibarakaiev I fixed it for all my pull requests. Tell me if you want that I do the same for my first pull request that includes many products.

[milesmcc]

@erotavlasme it looks like your new pull requests have the same issue:

What I really recommend you do is look at each product, create a new branch based on the current PrivacySpy master branch, and then create the files for only one product on that branch. When you submit a pull request, only commits related to the new product should show up. Note that it's not possible to achieve the same effect by deleting files; we care quite a bit about the revision history.

We really appreciate all your hard work. Doing the PRs in the proper format just help us keep the repository and its history clean.

[erotavlasme]

Well, in theory it would be enough to take a look at the number of different files since I'm adding a new product. As you can see, now each branch has one product and two files (except two products in case of proton).

However, I will do it from scratch in order to move forward.