Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMSPool #184

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Add SMSPool #184

merged 8 commits into from
Sep 9, 2024

Conversation

smspool
Copy link
Contributor

@smspool smspool commented Jun 5, 2024

Type of pull request: product addition
Related issues: list the related issues here (if applicable)


Privacy policy: https://www.smspool.net/privacy-policy
Terms of service: https://www.smspool.net/tos

Provide more information about your pull request here. For help, see our contribution guide: http://privacyspy.org/contribute/

Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good start. I'll approve checks and look it over once some changes are made.

products/smspool.toml Outdated Show resolved Hide resolved
products/smspool.toml Outdated Show resolved Hide resolved
products/smspool.toml Show resolved Hide resolved
products/smspool.toml Show resolved Hide resolved
products/smspool.toml Outdated Show resolved Hide resolved
products/smspool.toml Show resolved Hide resolved
products/smspool.toml Show resolved Hide resolved
products/smspool.toml Outdated Show resolved Hide resolved
products/smspool.toml Outdated Show resolved Hide resolved
@doamatto doamatto self-assigned this Jun 5, 2024
@doamatto doamatto added size/XS product Related to a product on PrivacySpy labels Jun 5, 2024
@smspool
Copy link
Contributor Author

smspool commented Jun 5, 2024

Cheers for the input, I will work on it now.

Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait and thanks for your patience. Just a few more things (and making sure the tests pass) and then I can get this merged for you (no new comments, just add-ons to the ones above).

- Updated description to use more neutral wording
- Adjusted score for security
- Added CF to noncritical
@doamatto
Copy link
Collaborator

doamatto commented Sep 9, 2024

Waiting for checks to pass, but will merge shortly after. Thanks !

@doamatto doamatto merged commit f4f3893 into Politiwatch:master Sep 9, 2024
5 checks passed
@smspool
Copy link
Contributor Author

smspool commented Sep 9, 2024

Not a problem, thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product Related to a product on PrivacySpy size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants