Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(products): add Obsidian #161

Merged
merged 4 commits into from
Jun 16, 2023
Merged

feat(products): add Obsidian #161

merged 4 commits into from
Jun 16, 2023

Conversation

doamatto
Copy link
Collaborator

Type of pull request: product addition

Related issues: NA

Going through this, consideration should be made for the rubric.security and downgrading somewhat to something like basic – so many services give the same basic spiel.

@doamatto doamatto self-assigned this Jun 16, 2023
@doamatto doamatto marked this pull request as ready for review June 16, 2023 00:31
@doamatto doamatto requested a review from milesmcc June 16, 2023 00:31
milesmcc
milesmcc approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@milesmcc milesmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point taken re: security. I do think that "somewhat" ultimately captures the spiel (as you put it), but it's definitely getting diluted.

@milesmcc milesmcc merged commit a2aa919 into master Jun 16, 2023
@doamatto doamatto deleted the add-obsidian branch June 16, 2023 19:43
@adamlui adamlui mentioned this pull request Jul 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milesmcc milesmcc milesmcc approved these changes

Assignees

@doamatto doamatto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doamatto @milesmcc