Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(products): Added Sans Institute (sansorg) #157

Merged
merged 7 commits into from
Jun 15, 2023

Conversation

ItsIgnacioPortal
Copy link
Contributor

Type of pull request: product addition


The product slug is sansorg instead of sans because I saw that sans.edu has it's own privacy policy, so using this unique slug should avoid a possible conflict in the future:

When we refer to “Websites” we mean www.sans.org as well as the other websites that we operate and that link to this Policy. Note that GIAC has its own privacy policy at www.giac/privacy, and SANS Technical Institute has its own Privacy Policy at www.sans.edu/privacy. This Policy does not apply to personal information collected and processed by GIAC or the SANS Technical Institute.

Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. A few changes and it should be good to go.

[rubric.data-breaches]
value = "no"
notes = [
"Despite the SANS Institute being a beacon in the cybersecurity industry, whose sole focus is on cybersecurity, their privacy policy does not specify a data breach protocol. It also notes the following:",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language here is a bit passive agressive – the note afterwords would be better for rubric.security, if at all.

Copy link
Contributor Author

@ItsIgnacioPortal ItsIgnacioPortal Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've shortened that note now. But I feel like it's important that we mention this, as it may otherwise come as a surprise for most users of SANS. Do you have any suggestions for a more professional phrasing?

products/sansorg.toml Show resolved Hide resolved
products/sansorg.toml Show resolved Hide resolved
products/sansorg.toml Show resolved Hide resolved
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing. Looks good otherwise !

products/sansorg.toml Outdated Show resolved Hide resolved
@doamatto doamatto merged commit 803f009 into Politiwatch:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants