-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(products): Added Sans Institute (sansorg) #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. A few changes and it should be good to go.
products/sansorg.toml
Outdated
[rubric.data-breaches] | ||
value = "no" | ||
notes = [ | ||
"Despite the SANS Institute being a beacon in the cybersecurity industry, whose sole focus is on cybersecurity, their privacy policy does not specify a data breach protocol. It also notes the following:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language here is a bit passive agressive – the note afterwords would be better for rubric.security
, if at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've shortened that note now. But I feel like it's important that we mention this, as it may otherwise come as a surprise for most users of SANS. Do you have any suggestions for a more professional phrasing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing. Looks good otherwise !
excesive -> excessive wheter -> whether
Type of pull request: product addition
The product slug is
sansorg
instead ofsans
because I saw that sans.edu has it's own privacy policy, so using this unique slug should avoid a possible conflict in the future: