Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(products): Added Stripe #156

Merged
merged 7 commits into from
Aug 9, 2023
Merged

feat(products): Added Stripe #156

merged 7 commits into from
Aug 9, 2023

Conversation

Deivedux
Copy link
Contributor

@Deivedux Deivedux commented Apr 9, 2023

Type of pull request: product addition

Related issues: Only during the opening of this pull request did I notice that behavioral-marketing may be conflicting with third-party-collection in some way. Please let me know of any issues you may have with this version.


I decided not to add their security policy as a source, since the only one they have is for their API and not for the personal data processing, which, I think, is irrelevant here.

@doamatto doamatto self-requested a review April 9, 2023 19:31
@doamatto doamatto added product Related to a product on PrivacySpy size/M labels Apr 9, 2023
products/stripe.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid start. Here's a few things I would change. Re-request the review when you think it's good for another look over.

products/stripe.toml Outdated Show resolved Hide resolved
products/stripe.toml Outdated Show resolved Hide resolved
products/stripe.toml Outdated Show resolved Hide resolved
products/stripe.toml Outdated Show resolved Hide resolved
products/stripe.toml Outdated Show resolved Hide resolved
products/stripe.toml Outdated Show resolved Hide resolved
@doamatto doamatto changed the title added Stripe feat(products): Added Stripe Apr 18, 2023
@Deivedux Deivedux requested a review from doamatto July 11, 2023 18:36
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more quick thing with the other comment. Sorry about the wait for me to get to this.

products/stripe.toml Outdated Show resolved Hide resolved
@Deivedux Deivedux requested a review from doamatto July 28, 2023 11:02
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get this fixed real quick, and I'll merge it today.

products/stripe.toml Outdated Show resolved Hide resolved
@doamatto doamatto merged commit cd521a6 into Politiwatch:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product Related to a product on PrivacySpy size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants