-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OMNY + Nebula #147
Added OMNY + Nebula #147
Conversation
I also added the files for Nebula, which seem to have been added to this PR automatically. |
Also, I am not sure why the checks are failing as I cannot find any information on what they are checking for. |
I approved it to run all the checks now, which should give you some more information. I'll take a look at the product files in a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what I've got so far; I'll look at it again once changes are made.
Made some changes to try and resolve some of the issues 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some more changes for products/nebula.toml
. I'll check the OMNY file later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a few more requested changes for you. I'll check back once I see the tests passing or if you let me know sooner.
- Fix TOML formatting - Improve line formatting - Fix score for list-collected
- Updated score and citation behavioral-marketing (no -> yes-opt-out) - Updated citation for data-breaches - Updated data-collection-reasoning (no -> mostly) - Updated citation for data-deletion - Updated score and citation for history (no -> last-modified) - Updated score and citation for law-enforcement (strict -> reasonable) - Updated score and citation for list-collected (no -> generally) - Updated score and citation for noncritical-purposes (no -> opt-out-some) - Updated citation for revision-notify - Updated score and citation for security (no -> somewhat) - Updated score and citation for third-party-access (yes-unspecified-critical -> yes-unspecified) - Updated score and citation for third-party-collection (no -> yes)
Type of pull request: product addition
Related issues: closes #142.