Add product API endpoint #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request. @milesmcc has been assigned to review these changes, provide feedback, and determine next steps. If you haven't already, please ensure your changes pass all the automated tests. Look in the "Checks" box below and "Files changed" tab to see test results. To learn about the PrivacySpy contribution process, check out the contribution guide.
|
privacyspy-bot
bot
added
size/XXL
code
milesmcc
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request: API improvement
Related issues: Closes #101.
As noted in the linked issue, it can sometimes be helpful to have an API endpoint for individual products, which is what this PR implements. It also fixes a concurrency issue in the current API that leads to dates being empty (the new implementation #96 implements
lastUpdatedas a promise but the API implementation remained synchronous).