Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch update #1: index, about, navbar, global styles #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StraubCreative
Copy link
Collaborator

@StraubCreative StraubCreative commented May 22, 2017

5.22.17

global

  • Added search form for Navbar
  • Created head.html partial and included for all pages
  • Created styles.css for custom app styles

/index

  • Added “splash page” layout
  • redesigned jumbotron by adjusting existing content and adding search feature

/about

  • added bootstrap layout + touched up sections

Bugs, future features and chores listed under Projects

@citizenM
Copy link
Contributor

• I really like the search function on in the jumbotron, I think it's a nice touch. That being said, I think the white background of the text doesn't contrast very much with the jumbotron, and maybe could be retouched.

• Is there any way to get spacing between the deleted tweets?

• I've always put icons before the text — you're welcome to do otherwise, but it seems a bit strange to me.

• The search bar could use a bit of touching up. On my computer it looks a bit big and bulky.

Definitely a step in the right direction! I like the search function. Great work here. I don't think it'd be best to merge into master at this point (all the backend stuff hasn't been changed to support the changes yet), so could we continue to work in this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants