-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GL4ES: HOLY EDITION #3019
GL4ES: HOLY EDITION #3019
Conversation
How holy |
I KNEW IT ITZ HOLY HOLY HOLLYYY |
Change gl4es to gl4es_extra; Build and upload .aab file only on push on mainline;
Holy moly macaroni |
HOLLY I SAY HOLYYYYYY THE GODSSSS HAVVEVEVEV BLESSSS USSSSS SEE |
Does it mean performace improvements on gles 3.0 |
Oh mai gawd |
I don't see any problem, maybe related to your device ? |
vanilla works but it does not to convert other shaders like from sodium |
You need opengles 3.0 to run the game perfectly |
use optifine optifine works |
not really because optifine runs |
It is written in the pr description that you need opengles 3.2 to run the game perfectly otherwise you need the assets-v0 file |
yes most phones have opengl es 3.2 |
but not every phone has gles 3.2 |
So would there be support for converting shaders loaded by sodium?? |
Why you must use sodium? There's other excellent fabric optimization mods too, also even optifabtic works now |
Bro nothing comes close to what sodium does |
And sodium is the only rendering optimization mod on fabric, optifine is bloat. |
Starlight, entityculling, lithium, better fps mod and more, not only sodium |
they optimize game logic not the rendering |
I changed sodium shaders but it seems to get cut off after some code leading to ";" token expected error |
latestlog.txt |
I tried vanilla shader code, simple glShaderSource, |
GL4ES: HOLY EDITION 🌠
Ladies and gentlemen, entities of the internet, TODAY we are here to celebrate the arrival of the one and only: GL4ES - HOLY EDITION !
"Why ?" I hear you ask ? Simple my child, simple really.
Native 1.17+ support
Turns out that I could just apply some of my shader convertion tricks, such as:
Yes, this does require opengles 3.0 + to properly work. Older devices, if they can stomach those versions at all, will still require the patch.
1.7.10 crash fix
Oh yeah, remember this issue from v3.3.1.1 ?
Thanks to the blessing of this 👼holy👼 version, the crashing is no more.
Also it was due to an issue with testing the sizeof() an int instead of a byte
Older versions QoL
Since older versions fare much better with openGL 1 (avoids crashes and "halved lighting" issues), some auto detection is added into the launcher to select the appropriate opengl version for you.
Note: I'm aware that some modded old versions cannot be detected.
Miscenalleous
Less impressive changes, although noteworthy ones are: