-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The great refactor #2811
Merged
artdeell
merged 50 commits into
PojavLauncherTeam:v3_openjdk
from
Mathias-Boulay:the_great_refactor
Mar 10, 2022
Merged
The great refactor #2811
artdeell
merged 50 commits into
PojavLauncherTeam:v3_openjdk
from
Mathias-Boulay:the_great_refactor
Mar 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REFACTORING THE PIRATES |
REFACTORING THE CHILDREN |
REFACTORING THE ORPHANS |
REFACTORING THE MICROSOFT |
Ok went a bit far there |
Mathias-Boulay
force-pushed
the
the_great_refactor
branch
from
March 8, 2022 20:20
7452dc3
to
30777cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Great Refactor
For the ones who ever took a dive into the codebase, you may have realized how messy the codebase is, mainly due to the inconsistency in both naming and code style.
This PR attempts at solving this issue by introducing both some code style and naming conventions, basing itself from a handy premade guideline that I didn't have to redact
Changes highlights:
try catch
blocksNotes:
Not all files were changed, for multiple reasons:
I may just have missed them when going through the files 😅
I couldn't find a fitting name, and we have other matters to deal with.
Some parts of the code will be reworked/rewrote soon, making the refactoring pointless
Also some dialogs have the system theme for now 😅