Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The great refactor #2811

Merged

Conversation

Mathias-Boulay
Copy link
Contributor

@Mathias-Boulay Mathias-Boulay commented Feb 26, 2022

The Great Refactor

For the ones who ever took a dive into the codebase, you may have realized how messy the codebase is, mainly due to the inconsistency in both naming and code style.

This PR attempts at solving this issue by introducing both some code style and naming conventions, basing itself from a handy premade guideline that I didn't have to redact

Changes highlights:

  • Many, MANY variables have been renamed
  • Some redundant blocks of code have been removed
  • Scopes of some variables have been reduced
  • Reduced the scope of Exception catching to avoid hiding underlying issue
  • Reduced the number of instructions inside try catch blocks
  • Reduced the number of deprecated functions being used
  • Flattened out part of the code

Notes:

Not all files were changed, for multiple reasons:
I may just have missed them when going through the files 😅
I couldn't find a fitting name, and we have other matters to deal with.
Some parts of the code will be reworked/rewrote soon, making the refactoring pointless

Also some dialogs have the system theme for now 😅

@jtghph
Copy link
Contributor

jtghph commented Feb 26, 2022

REFACTORING THE PIRATES

@CriticalRange
Copy link
Contributor

REFACTORING THE PIRATES

REFACTORING THE CHILDREN

@jtghph
Copy link
Contributor

jtghph commented Feb 26, 2022

REFACTORING THE PIRATES

REFACTORING THE CHILDREN

REFACTORING THE ORPHANS

@CriticalRange
Copy link
Contributor

REFACTORING THE PIRATES

REFACTORING THE CHILDREN

REFACTORING THE ORPHANS

REFACTORING THE MICROSOFT

@CriticalRange
Copy link
Contributor

Ok went a bit far there

@Mathias-Boulay Mathias-Boulay changed the title [DO NOT MERGE] The great refactor The great refactor Mar 8, 2022
@Mathias-Boulay Mathias-Boulay marked this pull request as ready for review March 8, 2022 17:39
@artdeell artdeell merged commit bcec329 into PojavLauncherTeam:v3_openjdk Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants