Override Python list modifying methods to capture and preserve changes to Struct list fields #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to Struct list fields Signed-off-by: Petr Ogarok <[email protected]>
ogarokpeter
requested review from
AdamGlustein,
alexddobkin,
czgdp1807,
ptomecek,
robambalu,
svatasoiu and
timkpaine
as code owners
robambalu
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue when users create a csp.Struct with a typed list field (
[int]) and try to modify this list field in Python, only to find that their changes are lost. The issue occurred because the typed list fields are stored as C++ vectors, and Python changes to those fields are not mirrored on them by mutating operations. My change implements such mirroring by creating a wrapper type for typed list fields, PyStructList, and capturing all list-mutating Python operations via Python C API.