-
Notifications
You must be signed in to change notification settings - Fork 3
Update PolarsExpression to just be a type annotation on pl.Expr #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ssing Signed-off-by: Nijat Khanbabayev <[email protected]>
Test Results443 tests +2 439 ✅ +2 25s ⏱️ -1s Results for commit c8aaf03. ± Comparison against base commit 5013e5e. This pull request removes 6 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 95.12% 95.13% +0.01%
==========================================
Files 126 126
Lines 7158 7178 +20
Branches 470 470
==========================================
+ Hits 6809 6829 +20
Misses 231 231
Partials 118 118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Nijat Khanbabayev <[email protected]>
Signed-off-by: Nijat Khanbabayev <[email protected]>
ef6316c to
b19dfb3
Compare
Signed-off-by: Nijat Khanbabayev <[email protected]>
Signed-off-by: Nijat Khanbabayev <[email protected]>
Signed-off-by: Nijat Khanbabayev <[email protected]>
without subclassing.
This follows the approach highlighted here: https://docs.pydantic.dev/latest/concepts/types/#handling-third-party-types
on the pydantic documentation.
This will be a breaking change because
PolarsExpressionno longer has avalidateclassmethod