Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show automated boosts in the Boosts tab #73

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

ericpp
Copy link
Collaborator

@ericpp ericpp commented Oct 25, 2023

Shows a clock icon next to automated boosts:

image

Resolves #67 #71

@ericpp
Copy link
Collaborator Author

ericpp commented Oct 25, 2023

Interestingly, most "no action" boosts are currently being classified as streams due to d_action defaulting to stream:

helipad/src/main.rs

Lines 139 to 141 in 91e61b7

fn d_action() -> Option<String> {
Some("stream".to_string())
}

@daveajones
Copy link
Contributor

Interestingly, most "no action" boosts are currently being classified as streams due to d_action defaulting to stream:

helipad/src/main.rs

Lines 139 to 141 in 91e61b7

fn d_action() -> Option<String> {
Some("stream".to_string())
}

That still feels like the right behavior to me. Do you agree?

@ericpp
Copy link
Collaborator Author

ericpp commented Oct 25, 2023

That still feels like the right behavior to me. Do you agree?

My thinking was that "no action" payments are more likely to be one-time payments (boosts) rather than per-minute payments (streams). That said, maybe it is safer to keep them in the streams tab in case some app is sending per-minute payments with the action field missing.

@daveajones
Copy link
Contributor

Probably no right answer here. I’m good with whatever you think.

@ericpp ericpp changed the title Show automated and no action boosts in the Boosts tab Show automated boosts in the Boosts tab Jan 30, 2024
@ericpp
Copy link
Collaborator Author

ericpp commented Jan 30, 2024

No action case can be handled by #71

@ericpp ericpp merged commit 6229c4d into Podcastindex-org:main Jan 30, 2024
@ericpp ericpp deleted the add-auto-noaction-boosts branch January 30, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display automated boosts
2 participants